Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency #31523

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Remove unused dependency #31523

merged 3 commits into from
Jul 15, 2021

Conversation

udda1996
Copy link
Contributor

@udda1996 udda1996 commented Jul 1, 2021

Purpose

Cleanup unused dependency declarations in some files.

Fixes #30853

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #31523 (caf2dd1) into master (000126c) will increase coverage by 56.43%.
The diff coverage is 72.73%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #31523       +/-   ##
=============================================
+ Coverage     14.59%   71.03%   +56.43%     
- Complexity        0    38910    +38910     
=============================================
  Files            51     2869     +2818     
  Lines          1411   158634   +157223     
  Branches        219    20007    +19788     
=============================================
+ Hits            206   112681   +112475     
- Misses         1189    39387    +38198     
- Partials         16     6566     +6550     
Impacted Files Coverage Δ
...shell/cli/handlers/help/HelpProviderException.java 0.00% <0.00%> (ø)
...allerina/shell/cli/jline/JlineBallerinaParser.java 0.00% <0.00%> (ø)
.../io/ballerina/shell/cli/jline/JlineParsedLine.java 0.00% <0.00%> (ø)
...allerina/shell/cli/jline/JlineSimpleCompleter.java 0.00% <0.00%> (ø)
...allerina/shell/exceptions/TreeParserException.java 0.00% <0.00%> (ø)
...a/shell/parser/trials/ParserRejectedException.java 0.00% <0.00%> (ø)
...shell/cli/handlers/help/RemoteBbeHelpProvider.java 3.22% <3.22%> (ø)
...rina/shell/parser/trials/GetErrorMessageTrial.java 8.10% <8.10%> (ø)
...a/io/ballerina/shell/cli/handlers/HelpCommand.java 20.00% <20.00%> (ø)
...n/java/io/ballerina/shell/cli/utils/FileUtils.java 23.80% <23.80%> (ø)
... and 2984 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da63bd...caf2dd1. Read the comment docs.

@keizer619 keizer619 merged commit 0f66496 into ballerina-platform:master Jul 15, 2021
@udda1996 udda1996 deleted the tharindu-lint branch October 1, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup unnecessary dependencies
3 participants