Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #30837

Merged
merged 5 commits into from
May 28, 2021
Merged

Conversation

keizer619
Copy link
Member

@keizer619 keizer619 commented May 28, 2021

Purpose

Following unnecessary dependencies which had security issues

  • commons-beanutils dependency
  • libthrift
  • guava

Following dependencies have been updated

  • netty-codec-http
  • netty-codec-http2
  • quartz
  • netty-handler

ballerina-platform/ballerina-distribution#1720

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #30837 (38cd143) into master (7f49301) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #30837   +/-   ##
=========================================
  Coverage     69.12%   69.12%           
- Complexity    38178    38179    +1     
=========================================
  Files          2906     2906           
  Lines        159780   159779    -1     
  Branches      20046    20046           
=========================================
+ Hits         110444   110447    +3     
+ Misses        42837    42835    -2     
+ Partials       6499     6497    -2     
Impacted Files Coverage Δ
...ontext/RecordFieldWithDefaultValueNodeContext.java 60.00% <0.00%> (-2.23%) ⬇️
...llerina/runtime/internal/scheduling/Scheduler.java 71.16% <0.00%> (-1.50%) ⬇️
...inalang/formatter/core/FormattingTreeModifier.java 94.62% <0.00%> (-0.01%) ⬇️
...roviders/context/ImportDeclarationNodeContext.java 83.33% <0.00%> (+0.30%) ⬆️
...runtime/internal/scheduling/WorkerDataChannel.java 85.98% <0.00%> (+1.27%) ⬆️
.../ballerina/runtime/internal/scheduling/Strand.java 81.63% <0.00%> (+1.53%) ⬆️
.../java/io/ballerina/projects/PackageResolution.java 89.39% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f49301...38cd143. Read the comment docs.

@keizer619 keizer619 changed the title Remove commons-beanutils dependency Remove unnecessary dependencies May 28, 2021
@keizer619 keizer619 requested a review from warunalakshitha May 28, 2021 13:00
dist 'com.github.jknack:handlebars:4.0.6'
dist 'com.sun.mail:javax.mail:1.6.2'
dist 'jaxen:jaxen:1.1.6'
dist 'io.netty:netty-buffer:4.1.39.Final'
dist 'io.netty:netty-codec-http2:4.1.39.Final'
dist 'io.netty:netty-codec-http:4.1.39.Final'
dist 'io.netty:netty-codec-http2:4.1.59.Final'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need netty dependencies in ballerina-lang?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places these are still referred like here and even in some tests
https://github.com/ballerina-platform/ballerina-lang/blob/master/bvm/ballerina-core/build.gradle#L31

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway we need to clean the whole repo and distribution packing dependencies with another effort.
#30853

@keizer619 keizer619 merged commit f63784c into ballerina-platform:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants