-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependencies #30837
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30837 +/- ##
=========================================
Coverage 69.12% 69.12%
- Complexity 38178 38179 +1
=========================================
Files 2906 2906
Lines 159780 159779 -1
Branches 20046 20046
=========================================
+ Hits 110444 110447 +3
+ Misses 42837 42835 -2
+ Partials 6499 6497 -2
Continue to review full report at Codecov.
|
dist 'com.github.jknack:handlebars:4.0.6' | ||
dist 'com.sun.mail:javax.mail:1.6.2' | ||
dist 'jaxen:jaxen:1.1.6' | ||
dist 'io.netty:netty-buffer:4.1.39.Final' | ||
dist 'io.netty:netty-codec-http2:4.1.39.Final' | ||
dist 'io.netty:netty-codec-http:4.1.39.Final' | ||
dist 'io.netty:netty-codec-http2:4.1.59.Final' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need netty dependencies in ballerina-lang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some places these are still referred like here and even in some tests
https://github.com/ballerina-platform/ballerina-lang/blob/master/bvm/ballerina-core/build.gradle#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway we need to clean the whole repo and distribution packing dependencies with another effort.
#30853
Purpose
Following unnecessary dependencies which had security issues
Following dependencies have been updated
ballerina-platform/ballerina-distribution#1720