Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the regex used to identify module ids in Ballerina Shell #29644

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Change the regex used to identify module ids in Ballerina Shell #29644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...modules/shell-core/src/main/java/io/ballerina/shell/invoker/classload/ImportsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ public class ImportsManager {
// Regex patterns
private static final Pattern CLONEABLE_SIGNATURE_PATTERN =
Pattern.compile("readonly\\|xml<[^>]*>\\|\\(Cloneable\\)\\[]\\|map<Cloneable>\\|table<map<Cloneable>>");
private static final Pattern FULLY_QUALIFIED_MODULE_ID_PATTERN = Pattern.compile("([\\w]+)/([\\w.]+):([\\d.]+):");
private static final Pattern FULLY_QUALIFIED_MODULE_ID_PATTERN =
MaryamZi marked this conversation as resolved.
Show resolved Hide resolved
Pattern.compile("([\\w]+)/([\\w.]+):([^:]+):([\\w]+)[|]?");
// Special imports
private static final String CLONEABLE_TYPE_DEF = "ballerina/lang.value:0:Cloneable";
private static final String JAVA_IMPORT_SOURCE = "import ballerina/jballerina.java;";
Expand Down