Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the regex used to identify module ids in Ballerina Shell #29644

Merged

Conversation

kdsuneraavinash
Copy link
Contributor

Purpose

Fixes #29366

Approach

Change the regex to identify module ids with alphanumeric characters

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@MaryamZi MaryamZi added this to the Ballerina Swan Lake - Alpha4 milestone Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #29644 (853fad8) into master (30c21cd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29644      +/-   ##
============================================
- Coverage     68.08%   68.08%   -0.01%     
+ Complexity    35267    35265       -2     
============================================
  Files          2816     2816              
  Lines        152569   152570       +1     
  Branches      18531    18531              
============================================
- Hits         103883   103873      -10     
- Misses        42527    42537      +10     
- Partials       6159     6160       +1     
Impacted Files Coverage Δ Complexity Δ
...lerina/shell/invoker/classload/ImportsManager.java 90.47% <100.00%> (+0.11%) 19.00 <0.00> (ø)
...runtime/internal/scheduling/WorkerDataChannel.java 84.71% <0.00%> (-6.37%) 34.00% <0.00%> (-1.00%)
.../ballerina/runtime/internal/scheduling/Strand.java 78.33% <0.00%> (-1.12%) 43.00% <0.00%> (-1.00%)
...ang/compiler/semantics/model/types/BUnionType.java 71.11% <0.00%> (-1.12%) 63.00% <0.00%> (-2.00%)
.../compiler/bir/codegen/interop/JMethodResolver.java 78.04% <0.00%> (+0.27%) 184.00% <0.00%> (+1.00%)
...n/java/io/ballerina/projects/bala/BalaProject.java 76.47% <0.00%> (+11.76%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c21cd...853fad8. Read the comment docs.

@MaryamZi MaryamZi merged commit dc94c4d into ballerina-platform:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ballerina Shell does not work with external modules that have alphanumeric characters in the version
2 participants