Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The code coverage shown less but the whole file is covered #42141

Closed
aashikam opened this issue Feb 12, 2024 · 3 comments · Fixed by ballerina-platform/module-ballerinax-aws.redshift#17
Assignees
Labels
Area/TestFramework Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Bug

Comments

@aashikam
Copy link
Contributor

Description

The code coverage of the native java files is shown as covered less(1.32%) although the executable code is covered.

Screenshot 2024-02-11 at 22 43 27 Screenshot 2024-02-11 at 22 43 21

Steps to Reproduce

No response

Affected Version(s)

module-ballerinax-aws.redshift:1.0.0
ballerinaLangVersion=2201.8.0

OS, DB, other environment details and versions

No response

Related area

-> Other Area

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@ballerina-bot ballerina-bot added the needTriage The issue has to be inspected and labeled manually label Feb 12, 2024
@gayaldassanayake gayaldassanayake added Area/TestFramework Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) and removed needTriage The issue has to be inspected and labeled manually labels Feb 12, 2024
@gayaldassanayake gayaldassanayake self-assigned this Feb 12, 2024
@gayaldassanayake
Copy link
Contributor

gayaldassanayake commented Feb 13, 2024

This is due to an issue in jacoco code coverage. the aws.redshift uses ballerina/sql as a dependency. Both sql and redshift contains the below 3 classes with the same class name.

CallProcessor
QueryProcessor
ExecuteProcessor

This results in the coverage data getting mixed up. A similar issue has been found in websocket where http and websocket share the same class names - issue.

This can be fixed by adding a --include filter to the bal test command. Will introduce this as a fix to the aws.redshift module.

@aashikam
Copy link
Contributor Author

Thank you for looking into this!

Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/TestFramework Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Bug
Projects
Archived in project
3 participants