Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Investigate the possibility for using the CustomToolClassLoader for Compiler plugins #42077

Closed
gayaldassanayake opened this issue Jan 31, 2024 · 2 comments
Assignees
Labels
Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Task

Comments

@gayaldassanayake
Copy link
Contributor

Description

Any bal tool runs with a custom class loader that prioritises the child jars over parent jars.

However, when trying to load a package within the tool and compile, and if that package contains compiler plugins, The compiler plugin does not use the parent CustomToolClassLoader. It uses the app class loader.

This has caused issues in service loading during the implementation of bal scan.

Describe your task(s)

[ ] - Check the feasibility of changing the compiler plugin related class loader creation to use the parent, in this case CustomToolClassLoader
[ ] - Introduce this to the 2201.8.5 fix

Related area

-> Compilation

Related issue(s) (optional)

#41957

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Jan 31, 2024
@gayaldassanayake gayaldassanayake added Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) and removed needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Jan 31, 2024
@gayaldassanayake gayaldassanayake self-assigned this Jan 31, 2024
@gayaldassanayake
Copy link
Contributor Author

This was delayed since the scan tool currently has a workaround as of now to

  • either add dependencies to bre/lib or
  • dump the report details into a file and re read

@gayaldassanayake gayaldassanayake moved this from In Progress to BackLog in Ballerina Team Main Board Feb 1, 2024
@gayaldassanayake
Copy link
Contributor Author

Closing since this requirement is no longer valid since scan tool is not following this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Task
Projects
Archived in project
Development

No branches or pull requests

2 participants