Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Config Generation fails to add the name of Readonly Records to the Config Schema #41906

Closed
chalindukodikara opened this issue Dec 19, 2023 · 4 comments · Fixed by #41914
Assignees
Labels
Reason/Other None of the other reasons. Type/Bug

Comments

@chalindukodikara
Copy link

chalindukodikara commented Dec 19, 2023

Description:
Config generation should include the record name in the config schema. However, when the record is read-only, it fails to include the record name.

Steps to reproduce:

  • Create two records with read only and without read only.
  • Generate config schema (bal build --generate-config-schema)

Sample Code: https://github.com/chalindukodikara/ballerina-codes/tree/master/config-generation-name-issue

Config Schema: https://github.com/chalindukodikara/ballerina-codes/blob/master/config-generation-name-issue/target/bin/config-schema.json

Related Issues (optional):
This issue affects Choreo Console for Ballerina components.
https://github.com/wso2-enterprise/choreo/issues/25862

Suggested Labels (optional):
Priority/High

@TharmiganK
Copy link
Contributor

This tool is implemented in the lang repository, hence transferring this issue

@Dilhasha
Copy link
Contributor

The type converter in config schema generation fails to add the name at https://github.com/ballerina-platform/ballerina-lang/blob/master/compiler/ballerina-lang/src/main/java/io/ballerina/projects/internal/configschema/TypeConverter.java#L185

The reason for this issue is a compiler bug which is reported at #41912

@MaryamZi
Copy link
Member

The reason for this issue is a compiler bug which is reported at #41912

Please see #41912 (comment).

Copy link

github-actions bot commented Jan 9, 2024

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reason/Other None of the other reasons. Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants