Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Language Server unresponsive after including a cyclic dependency #41111

Closed
malinthar opened this issue Jul 28, 2023 · 2 comments · Fixed by #41756
Closed

[Bug]: Language Server unresponsive after including a cyclic dependency #41111

malinthar opened this issue Jul 28, 2023 · 2 comments · Fixed by #41756
Assignees
Labels
Area/Completion Issues related to Language Server Auto Completions Reason/Complex Issue occurred due to complex scenario. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug
Milestone

Comments

@malinthar
Copy link
Contributor

Description

$subject as depicted below

cyclic_dependency

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@malinthar malinthar added Type/Bug Team/LanguageServer Language Server Implementation related issues. #Compiler labels Jul 28, 2023
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Jul 28, 2023
@malinthar malinthar added Area/Completion Issues related to Language Server Auto Completions Area/Compiler Area/ProjectAPI and removed needTriage The issue has to be inspected and labeled manually userCategory/Compilation Area/Compiler labels Jul 28, 2023
@azinneera
Copy link
Contributor

When there is a cyclic dependency, the compilation cannot be continued, so it is a crashed state. Hence this behavior is expected. The diagnostic is issued to indicate the cyclic dependency which can be used to resolve the error.

@malinthar
Copy link
Contributor Author

When there is a cyclic dependency, the compilation cannot be continued, so it is a crashed state. Hence this behavior is expected. The diagnostic is issued to indicate the cyclic dependency which can be used to resolve the error.

I see. However, the VSCode user might not know about the crashed state unless they look at the problems tab. The LS may seem unresponsive because features such as completion, code-action will not work without the compilation. To avoid the confusion we can send a notification from the LS side when the compilation is in a crashed state specifying a user error.

@nipunayf nipunayf self-assigned this Nov 13, 2023
@nipunayf nipunayf moved this to In Progress in Ballerina Team Main Board Nov 13, 2023
@nipunayf nipunayf moved this from In Progress to PR Sent in Ballerina Team Main Board Dec 9, 2023
@nipunayf nipunayf added the Reason/Complex Issue occurred due to complex scenario. label Dec 10, 2023
@github-project-automation github-project-automation bot moved this from PR Sent to Done in Ballerina Team Main Board Dec 18, 2023
@nipunayf nipunayf added this to the 2201.9.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Completion Issues related to Language Server Auto Completions Reason/Complex Issue occurred due to complex scenario. Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants