Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dependency update warning shows for new packages in VSCode #40597

Closed
azinneera opened this issue Jun 5, 2023 · 3 comments · Fixed by #41694
Closed

[Bug]: Dependency update warning shows for new packages in VSCode #40597

azinneera opened this issue Jun 5, 2023 · 3 comments · Fixed by #41694

Comments

@azinneera
Copy link
Contributor

azinneera commented Jun 5, 2023

Description

For new projects, there is no need to show the warning about the dependency update. This behavior is correct in the CLI build but the warning is shown in LS.

Steps to Reproduce

  1. Create a new package and open it is VSCode
  2. Execute bal build in the VSCode terminal
    Observation: The dependency update warning is shown in the Problems tab
  3. Open the Dependencies.toml
    Observation: The warning goes away

Expected behavior:
The warning should not be shown at all for a new package

Affected Version(s)

2201.5.0 and above

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@gayaldassanayake
Copy link
Contributor

I was able to reproduce the issue. Will provide a fix with #40522.

@gayaldassanayake
Copy link
Contributor

The fix was intended to go with #41197, however was not merged due to the concerns over the design.

Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants