Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible endpoints missed the client declarations with the @display annotation #39657

Closed
kanushka opened this issue Feb 20, 2023 · 3 comments · Fixed by #39816
Closed

Visible endpoints missed the client declarations with the @display annotation #39657

kanushka opened this issue Feb 20, 2023 · 3 comments · Fixed by #39816
Assignees
Labels
needTriage The issue has to be inspected and labeled manually Reason/Other None of the other reasons. Type/Bug userCategory/Compilation
Milestone

Comments

@kanushka
Copy link
Contributor

kanushka commented Feb 20, 2023

Description

Visible endpoints missed the client declarations with the @display annotation.

Steps to Reproduce

Try the below source and generate a custom syntax tree from diagram-util. It should contain InternalClient inEp3; as a visible endpoint in the /abc service. But the visible endpoint list will miss the inEp3 endpoint because of the @display annotation.

service /abc on new http:Listener(9090) {

    @display {
        label: "InternalClientService",
    }
    InternalClient inEp3;

    function init() returns error? {
        self.inEp3 = check new InternalClient("http://example.com/internal/1");
    }

    resource function get repos(string orgName, int max = 5) returns string|error? {

    }

}

Affected Version(s)

2201.3.1

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@kanushka
Copy link
Contributor Author

kanushka commented Mar 7, 2023

The issue has reopened since this issue needs to be fixed in immediately release.

@kanushka
Copy link
Contributor Author

kanushka commented Mar 7, 2023

The above PR will fix the issue for visible endpoint generation.
Created a separate issue to track the Sematic API issue #39812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needTriage The issue has to be inspected and labeled manually Reason/Other None of the other reasons. Type/Bug userCategory/Compilation
Projects
Archived in project
3 participants