Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set observabilityIncluded flag to true in all tests after adding a dummy ballerinai/observe module for tests #34595

Closed
nadundesilva opened this issue Jan 11, 2022 · 1 comment
Closed

Set observabilityIncluded flag to true in all tests after adding a dummy ballerinai/observe module for tests #34595

nadundesilva opened this issue Jan 11, 2022 · 1 comment
Labels
IceBox Older issues that are not being actively worked on but may be revisited in the future. Team/Observability Observability in general, Metrics, Tracing & Logging Type/Task

Comments

@nadundesilva
Copy link
Contributor

Description:
While moving ballerina/observe & ballerinai/observe modules out of the ballerina-lang repository, the observabilityIncluded flag was set to false in all the tests in ballerina-lang. This is due to the flag requiring the ballerinai/observe module to be present. However, we need to re-enable this in tests so that the instrumentation will be covered in test cases well.

Describe your task(s)

  • Create a dummy ballerinai/observe module which can be used used to set observabilityIncluded flag
  • Revert the changes done in Remove observability components #34507 PR to set observabilityIncluded to false

Related Issues (optional):
Observe Module Migration: #33195
@nadundesilva nadundesilva added Type/Task Team/Observability Observability in general, Metrics, Tracing & Logging labels Jan 11, 2022
@anupama-pathirage anupama-pathirage added the IceBox Older issues that are not being actively worked on but may be revisited in the future. label Nov 21, 2024
@anupama-pathirage
Copy link
Contributor

We are closing this issue due to inactivity. If you need further assistance or have additional input, feel free to reopen it. Thank you for helping us maintain a relevant and focused issue list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IceBox Older issues that are not being actively worked on but may be revisited in the future. Team/Observability Observability in general, Metrics, Tracing & Logging Type/Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nadundesilva @anupama-pathirage