Skip to content

Commit

Permalink
Address reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
gabilang committed Mar 14, 2024
1 parent d29b10e commit f196979
Show file tree
Hide file tree
Showing 21 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion langlib/jballerina.java/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.java {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.java;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.__internal/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.internal {
exports org.ballerinalang.langlib.internal;
requires io.ballerina.runtime;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.array/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.array {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.array;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.boolean/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.bool {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.bool;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.decimal/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.decimal {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.decimal;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.error/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
requires io.ballerina.runtime;
requires io.ballerina.identifier;
exports org.ballerinalang.langlib.error;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.float/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.floatingpoint {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.floatingpoint;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.future/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.future {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.future;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.int/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.integer {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.integer;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.map/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.map {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.map;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.query/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.query {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.query;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.regexp/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.regexp {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.regexp;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.string/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.string {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.string;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.table/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.table {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.table;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.test/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.test {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.test;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.transaction/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.transaction {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.transaction;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.typedesc/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.typedesc {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.typedesc;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.value/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module io.ballerina.lang.value {
requires io.ballerina.runtime;
exports org.ballerinalang.langlib.value;
}
}
2 changes: 1 addition & 1 deletion langlib/lang.xml/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
requires io.ballerina.lang.internal;
requires java.xml;
exports org.ballerinalang.langlib.xml;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import io.ballerina.runtime.api.values.BXml;
import io.ballerina.runtime.internal.errors.ErrorHelper;
import io.ballerina.runtime.internal.scheduling.Strand;
import org.ballerinalang.langlib.xml.utils.Lists;
import org.ballerinalang.langlib.xml.utils.XmlUtils;

/**
* Searches in children recursively for elements matching the name and returns a sequence containing them all.
Expand All @@ -45,7 +45,7 @@ public static BXml selectDescendants(Strand strand, BXml xml, BArray qnames) {
try {
// todo: this need to support list of qnames.
String qname = qnames.getString(0);
return (BXml) xml.descendants(Lists.of(qname));
return (BXml) xml.descendants(XmlUtils.getList(qname));
} catch (Throwable e) {
ErrorHelper.handleXMLException(OPERATION, e);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
*
* @since 2201.9.0
*/
public class Lists {
public class XmlUtils {

@SafeVarargs
public static <E> List<E> of(E... values) {
public static <E> List<E> getList(E... values) {
List<E> list = new ArrayList<>();
Collections.addAll(list, values);
return list;
Expand Down

0 comments on commit f196979

Please sign in to comment.