From de437cc32a6eb4546afb431533a4222549444919 Mon Sep 17 00:00:00 2001 From: Nipuna Ranasinghe Date: Fri, 13 Dec 2024 16:14:18 +0530 Subject: [PATCH] Fix build failures --- .../workspace/BallerinaWorkspaceManager.java | 13 +++++++------ .../modules/debug-adapter-core/spotbugs-exclude.xml | 11 ++++++++++- .../debugadapter/JBallerinaDebugServer.java | 4 ++-- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/workspace/BallerinaWorkspaceManager.java b/language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/workspace/BallerinaWorkspaceManager.java index d0aee031e275..62f216c92533 100644 --- a/language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/workspace/BallerinaWorkspaceManager.java +++ b/language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/workspace/BallerinaWorkspaceManager.java @@ -102,6 +102,7 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.locks.Lock; import java.util.concurrent.locks.ReentrantLock; + import javax.annotation.Nonnull; import javax.annotation.Nullable; @@ -120,7 +121,7 @@ public class BallerinaWorkspaceManager implements WorkspaceManager { private static final String USER_DIR = System.getProperty("user.dir"); private static final String HEAP_DUMP_FLAG = "-XX:+HeapDumpOnOutOfMemoryError"; private static final String HEAP_DUMP_PATH_FLAG = "-XX:HeapDumpPath="; - private static final String DEBUG_SOCKET_CONFIG = "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:"; + private static final String DEBUG_ARGS = "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:"; /** * Cache mapping of document path to source root. @@ -670,22 +671,22 @@ private Optional executeProject(ProjectContext projectContext, RunConte } } - private List prepareExecutionCommands(RunContext context, Module executableModule, JarResolver jarResolver) { + private List prepareExecutionCommands(RunContext context, Module module, JarResolver jarResolver) { List commands = new ArrayList<>(); commands.add(JAVA_COMMAND); commands.add(HEAP_DUMP_FLAG); commands.add(HEAP_DUMP_PATH_FLAG + USER_DIR); if (context.debugPort() > 0) { - commands.add(DEBUG_SOCKET_CONFIG + context.debugPort()); + commands.add(DEBUG_ARGS + context.debugPort()); } commands.add("-cp"); commands.add(getAllClassPaths(jarResolver)); String initClassName = JarResolver.getQualifiedClassName( - executableModule.packageInstance().packageOrg().toString(), - executableModule.packageInstance().packageName().toString(), - executableModule.packageInstance().packageVersion().toString(), + module.packageInstance().packageOrg().toString(), + module.packageInstance().packageName().toString(), + module.packageInstance().packageVersion().toString(), MODULE_INIT_CLASS_NAME ); commands.add(initClassName); diff --git a/misc/debug-adapter/modules/debug-adapter-core/spotbugs-exclude.xml b/misc/debug-adapter/modules/debug-adapter-core/spotbugs-exclude.xml index 7e528799f807..b541c72b23f8 100644 --- a/misc/debug-adapter/modules/debug-adapter-core/spotbugs-exclude.xml +++ b/misc/debug-adapter/modules/debug-adapter-core/spotbugs-exclude.xml @@ -61,7 +61,16 @@ - + + + + + + + + + + diff --git a/misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java b/misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java index e7181c330561..3ab74fd6d4ff 100755 --- a/misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java +++ b/misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java @@ -289,8 +289,8 @@ public CompletableFuture attach(Map args) { try { clientConfigHolder = new ClientAttachConfigHolder(args); context.setDebugMode(ExecutionContext.DebugMode.ATTACH); - Project sourceProject = context.getProjectCache().getProject(Path.of(clientConfigHolder.getSourcePath())); - context.setSourceProject(sourceProject); + Project srcProject = context.getProjectCache().getProject(Path.of(clientConfigHolder.getSourcePath())); + context.setSourceProject(srcProject); ClientAttachConfigHolder configHolder = (ClientAttachConfigHolder) clientConfigHolder; String hostName = configHolder.getHostName().orElse("");