Fix step-over behaviour for init methods

ballerina-platform · Nov 12, 2024 · d7a7723 · d7a7723
1 parent a2173fd
commit d7a7723
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/.../debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/BreakpointProcessor.java b/.../debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/BreakpointProcessor.java
@@ -234,7 +234,9 @@ void activateDynamicBreakPoints(int threadId, DynamicBreakpointMode mode, boolea
                 Location currentLocation = validFrames.get(0).getJStackFrame().location();
                 Optional<Location> prevLocation = context.getPrevLocation();
                 if (!validate || prevLocation.isEmpty() || !isWithinSameSource(currentLocation, prevLocation.get())) {
-                    doActivateDynamicBreakPoints(currentLocation);
+                    context.getEventManager().deleteAllBreakpoints();
+                    configureBreakpointsForMethod(currentLocation);
+                    context.setPrevLocation(currentLocation);
                 }
                 context.setPrevLocation(currentLocation);
             }
@@ -243,7 +245,11 @@ void activateDynamicBreakPoints(int threadId, DynamicBreakpointMode mode, boolea
             // temporary breakpoint on the location of its invocation. This is supposed to handle the situations where
             // the user wants to step over on an exit point of the current function.
             if (mode == DynamicBreakpointMode.CALLER && validFrames.size() > 1) {
-                doActivateDynamicBreakPoints(validFrames.get(1).getJStackFrame().location());
+                context.getEventManager().deleteAllBreakpoints();
+                for (int frameIndex = 1; frameIndex < validFrames.size(); frameIndex++) {
+                    configureBreakpointsForMethod(validFrames.get(frameIndex).getJStackFrame().location());
+                }
+                context.setPrevLocation(validFrames.get(0).getJStackFrame().location());
             }
         } catch (JdiProxyException e) {
             LOGGER.error(e.getMessage());
@@ -254,12 +260,6 @@ void activateDynamicBreakPoints(int threadId, DynamicBreakpointMode mode, boolea
         }
     }
 
-    private void doActivateDynamicBreakPoints(Location location) {
-        context.getEventManager().deleteAllBreakpoints();
-        configureBreakpointsForMethod(location);
-        context.setPrevLocation(location);
-    }
-
     /**
      * Checks whether the given two locations are within the same source file.
      *