-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve connector names returned by connector search #648
Merged
nipunayf
merged 6 commits into
ballerina-platform:main
from
nipunayf:fix-connector-names
Mar 5, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b570a86
Fix the connector name
nipunayf 8172296
Fix the fhir connector name
nipunayf d078bfa
Fix the names of the protocols
nipunayf 099de48
Add ftp to the landing page
nipunayf dad6e3b
Move corrections to a file
nipunayf d927621
Fix the name of the persist modules
nipunayf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
...dules/flow-model-generator-ls-extension/src/main/resources/connector_name_correction.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "http": "HTTP", | ||
| "grpc": "gRPC", | ||
| "mysql": "MySQL", | ||
| "mssql": "MS SQL", | ||
| "mongodb": "MongoDB", | ||
| "aws.dynamodb": "DynamoDB", | ||
| "oracledb": "OracleDB", | ||
| "postgresql": "PostgreSQL", | ||
| "sql": "SQL", | ||
| "azure.sqldb": "SQLDB", | ||
| "aws.sqs": "SQS", | ||
| "mqtt": "MQTT", | ||
| "rabbitmq": "RabbitMQ", | ||
| "graphql": "GraphQL", | ||
| "googleapis.clouddatastore": "Cloud Datastore", | ||
| "health.clients.fhir": "FHIR", | ||
| "ftp": "FTP", | ||
| "udp": "UDP", | ||
| "tcp": "TCP", | ||
| "persist.sql": "Persist", | ||
| "persist.inmemory": "Persist", | ||
| "persist.googlesheets": "Persist", | ||
| "persist.redis": "Persist" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
| "websocket:Client", | ||
| "tcp:Client", | ||
| "udp:Client", | ||
| "ftp:Client", | ||
| "websub:Client" | ||
| ], | ||
| "Database": [ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...s/flow-model-generator-ls-extension/src/test/resources/search/config/connectors/fhir.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "description": "Sample flow model", | ||
| "kind": "CONNECTOR", | ||
| "source": "empty.bal", | ||
| "queryMap": { | ||
| "q": "fhir" | ||
| }, | ||
| "categories": [ | ||
| { | ||
| "metadata": { | ||
| "label": "FHIR FHIRConnector", | ||
| "description": "This connector allows you to connect and interact with any FHIR server", | ||
| "icon": "https://bcentral-packageicons.azureedge.net/images/ballerinax_health.clients.fhir_2.1.0.png" | ||
| }, | ||
| "codedata": { | ||
| "node": "NEW_CONNECTION", | ||
| "org": "ballerinax", | ||
| "module": "health.clients.fhir", | ||
| "object": "FHIRConnector", | ||
| "symbol": "init", | ||
| "version": "2.1.0" | ||
| }, | ||
| "enabled": true | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO having only the last part of the package name hierarchy may look ambiguous in many cases.
As an example, something like
Zoho CRM Rest Clientwould be a better option for the above scenario.Can't we improve our name generation logic accordingly (probably will have to extend the
CONNECTOR_NAME_MAP)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasithaa thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we make only the common one for now? Ideally this info should come from the library (or from the library team).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the package name appears under the label, so the information is still presented (not the best way tho).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, getting display names from the packages themselves would be ideal.
Until we get there, wouldn’t it be better to add custom mappings for other modules too? (+1 to doing it in a separate PR).
The main reason is that while pro-code users understand package names better, low-code users may find them (especially hierarchical ones) hard to grasp