Make inferred param readonly in node template

ballerina-platform · Mar 5, 2025 · fe5d6b1 · fe5d6b1
1 parent b1e5abb
commit fe5d6b1
Show file tree

Hide file tree

Showing 10 changed files with 12 additions and 13 deletions.
diff --git a/...rator-core/src/main/java/io/ballerina/flowmodelgenerator/core/model/node/CallBuilder.java b/...rator-core/src/main/java/io/ballerina/flowmodelgenerator/core/model/node/CallBuilder.java
@@ -110,7 +110,7 @@ public void setConcreteTemplateData(TemplateContext context) {
         setParameterProperties(functionData);
 
         if (CommonUtils.hasReturn(functionData.returnType())) {
-            setReturnTypeProperties(functionData, context, functionData.inferredReturnType(), Property.VARIABLE_NAME);
+            setReturnTypeProperties(functionData, context, Property.VARIABLE_NAME);
         }
 
         if (functionData.returnError()) {
@@ -171,10 +171,9 @@ protected void setParameterProperties(FunctionData function) {
         }
     }
 
-    protected void setReturnTypeProperties(FunctionData functionData, TemplateContext context, boolean editable,
-                                           String label) {
+    protected void setReturnTypeProperties(FunctionData functionData, TemplateContext context, String label) {
         properties()
-                .type(functionData.returnType(), editable, functionData.importStatements())
+                .type(functionData.returnType(), false, functionData.importStatements())
                 .data(functionData.returnType(), context.getAllVisibleSymbolNames(), label);
     }
 

diff --git a/...e/src/main/java/io/ballerina/flowmodelgenerator/core/model/node/NewConnectionBuilder.java b/...e/src/main/java/io/ballerina/flowmodelgenerator/core/model/node/NewConnectionBuilder.java
@@ -129,7 +129,7 @@ public void setConcreteTemplateData(TemplateContext context) {
         setParameterProperties(functionData);
 
         if (CommonUtils.hasReturn(functionData.returnType())) {
-            setReturnTypeProperties(functionData, context, false, CONNECTION_NAME_LABEL);
+            setReturnTypeProperties(functionData, context, CONNECTION_NAME_LABEL);
         }
 
         properties()

diff --git a/.../main/java/io/ballerina/flowmodelgenerator/core/model/node/ResourceActionCallBuilder.java b/.../main/java/io/ballerina/flowmodelgenerator/core/model/node/ResourceActionCallBuilder.java
@@ -92,7 +92,7 @@ public void setConcreteTemplateData(TemplateContext context) {
 
         String returnTypeName = functionData.returnType();
         if (CommonUtils.hasReturn(returnTypeName)) {
-            setReturnTypeProperties(functionData, context, functionData.inferredReturnType(), Property.VARIABLE_NAME);
+            setReturnTypeProperties(functionData, context, Property.VARIABLE_NAME);
         }
 
         if (functionData.returnError()) {

diff --git a/...-ls-extension/src/test/resources/node_template/config/function_call-json-parseString.json b/...-ls-extension/src/test/resources/node_template/config/function_call-json-parseString.json
@@ -104,7 +104,7 @@
         "value": "t",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {}
       },

diff --git a/...tor-ls-extension/src/test/resources/node_template/config/remote_action_call-http-get.json b/...tor-ls-extension/src/test/resources/node_template/config/remote_action_call-http-get.json
@@ -125,7 +125,7 @@
         "value": "targetType",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {}
       },

diff --git a/...or-ls-extension/src/test/resources/node_template/config/remote_action_call-http-post.json b/...or-ls-extension/src/test/resources/node_template/config/remote_action_call-http-post.json
@@ -179,7 +179,7 @@
         "value": "targetType",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {}
       },

diff --git a/...-ls-extension/src/test/resources/node_template/config/remote_action_call-mysql-query.json b/...-ls-extension/src/test/resources/node_template/config/remote_action_call-mysql-query.json
@@ -98,7 +98,7 @@
         "value": "stream<rowType, sql:Error?>",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {
           "importStatements": "ballerina/sql"

diff --git a/...-extension/src/test/resources/node_template/config/remote_action_call-mysql-queryRow.json b/...-extension/src/test/resources/node_template/config/remote_action_call-mysql-queryRow.json
@@ -98,7 +98,7 @@
         "value": "returnType",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {
           "importStatements": "ballerina/sql"

diff --git a/...extension/src/test/resources/node_template/config/remote_action_call-snowflake-query.json b/...extension/src/test/resources/node_template/config/remote_action_call-snowflake-query.json
@@ -96,7 +96,7 @@
         "value": "stream<rowType, sql:Error?>",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {
           "importStatements": "ballerina/sql"

diff --git a/...r-ls-extension/src/test/resources/node_template/config/resource_action_call-http-get.json b/...r-ls-extension/src/test/resources/node_template/config/resource_action_call-http-get.json
@@ -131,7 +131,7 @@
         "value": "targetType",
         "placeholder": "var",
         "optional": false,
-        "editable": true,
+        "editable": false,
         "advanced": false,
         "codedata": {}
       },