Merge pull request #594 from KavinduZoysa/change-api

Change json conversion API names
ballerina-platform · Feb 13, 2025 · 95a024b · 95a024b
2 parents 7b6ec84 + 058a1e0
commit 95a024b
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/...ore/src/main/java/io/ballerina/flowmodelgenerator/core/converters/JsonToRecordMapper.java b/...ore/src/main/java/io/ballerina/flowmodelgenerator/core/converters/JsonToRecordMapper.java
@@ -135,9 +135,6 @@ public JsonElement convert(String jsonString, boolean isRecordTypeDesc, boolean
         Map<String, NonTerminalNode> recordToTypeDescNodes = new LinkedHashMap<>();
         Map<String, JsonElement> jsonFieldToElements = new LinkedHashMap<>();
 
-        if (existingFieldNames.contains(this.recordName)) {
-            throw new JsonToRecordConverterException("Given record name already exists in the module");
-        }
         JsonElement parsedJson = JsonParser.parseString(jsonString);
         if (parsedJson.isJsonObject()) {
             generateRecords(parsedJson.getAsJsonObject(), null, isClosed, recordToTypeDescNodes, null,

diff --git a/...src/main/java/io/ballerina/flowmodelgenerator/extension/JsonToRecordConverterService.java b/...src/main/java/io/ballerina/flowmodelgenerator/extension/JsonToRecordConverterService.java
@@ -41,7 +41,7 @@
  * @since 2.0.0
  */
 @JavaSPIService("org.ballerinalang.langserver.commons.service.spi.ExtendedLanguageServerService")
-@JsonSegment("jsonToRecord")
+@JsonSegment("jsonToRecordTypes")
 public class JsonToRecordConverterService implements ExtendedLanguageServerService {
     private WorkspaceManager workspaceManager;
 
@@ -90,6 +90,6 @@ public CompletableFuture<JsonToRecordResponse> convert(JsonToRecordRequest reque
 
     @Override
     public String getName() {
-        return "jsonToRecord";
+        return "jsonToRecordTypes";
     }
 }
diff --git a/.../src/main/java/io/ballerina/flowmodelgenerator/extension/XMLToRecordConverterService.java b/.../src/main/java/io/ballerina/flowmodelgenerator/extension/XMLToRecordConverterService.java
@@ -41,7 +41,7 @@
  * @since 2.0.0
  */
 @JavaSPIService("org.ballerinalang.langserver.commons.service.spi.ExtendedLanguageServerService")
-@JsonSegment("xmlToRecord")
+@JsonSegment("xmlToRecordTypes")
 public class XMLToRecordConverterService implements ExtendedLanguageServerService {
     private WorkspaceManager workspaceManager;
 
@@ -92,6 +92,6 @@ public CompletableFuture<XMLToRecordResponse> convert(XMLToRecordRequest request
 
     @Override
     public String getName() {
-        return "jsonToRecord";
+        return "jsonToRecordTypes";
     }
 }
diff --git a/...-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/JsonConverterTest.java b/...-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/JsonConverterTest.java
@@ -99,7 +99,7 @@ protected String getApiName() {
 
     @Override
     protected String getServiceName() {
-        return "jsonToRecord";
+        return "jsonToRecordTypes";
     }
 
     private record TestConfig(String filePath, String testFilePath, String jsonString, String recordName,

diff --git a/...s-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/XMLConverterTest.java b/...s-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/XMLConverterTest.java
@@ -107,7 +107,7 @@ protected String getApiName() {
 
     @Override
     protected String getServiceName() {
-        return "xmlToRecord";
+        return "xmlToRecordTypes";
     }
 
     private record TestConfig(String filePath, String xmlString, String prefix, boolean isClosed,