Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Transform message format" tutorial #8

Merged

Conversation

dulajdilshan
Copy link
Contributor

Purpose

$title

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@dulajdilshan dulajdilshan changed the title Add "Transform message format" tutorial [Draft] Add "Transform message format" tutorial Sep 5, 2023
@dulajdilshan dulajdilshan marked this pull request as draft September 5, 2023 18:21
@dulajdilshan dulajdilshan force-pushed the tutorial/translate-messages branch from 27062c6 to e5447c7 Compare September 5, 2023 18:22
@dulajdilshan
Copy link
Contributor Author

Let's review the main.bal implementation and test.bal first, and then add the README.md

backends/hospital-service/main.bal Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/tests/test.bal Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/tests/test.bal Outdated Show resolved Hide resolved
transform-message-formats/tests/test.bal Outdated Show resolved Hide resolved
transform-message-formats/tests/test.bal Outdated Show resolved Hide resolved
transform-message-formats/tests/test.bal Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
transform-message-formats/main.bal Outdated Show resolved Hide resolved
@dulajdilshan dulajdilshan force-pushed the tutorial/translate-messages branch from 8567b7f to 26a4d03 Compare September 20, 2023 01:09
transform-message-formats/main.bal Outdated Show resolved Hide resolved
Comment on lines +56 to +57
@test:Config
function testInvalidDoctor() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, this test is kinda redundant, right? Since we have testInvalidHospital.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revisit the rest based on this. Can do separately.

transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
MaryamZi
MaryamZi previously approved these changes Sep 22, 2023
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
transform-message-formats/README.md Outdated Show resolved Hide resolved
@MaryamZi MaryamZi dismissed their stale review September 22, 2023 09:44

Approved by mistake.

@dulajdilshan dulajdilshan force-pushed the tutorial/translate-messages branch from b16ff5c to 69d0541 Compare September 22, 2023 10:07
@MaryamZi MaryamZi merged commit cac458c into ballerina-guides:main Sep 22, 2023
@dulajdilshan dulajdilshan deleted the tutorial/translate-messages branch September 23, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants