Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the code with less precision and uncommenting the code with … #434

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Removing the code with less precision and uncommenting the code with … #434

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0524628
Removing the code with less precision and uncommenting the code with …
Mar 7, 2024
6d5cd7f
Changing slightly different expected values on weighted pool tests;
Mar 7, 2024
3aee9a4
Changing more hardcoded expected values;
Mar 7, 2024
2f65219
Adding precision test;
Mar 11, 2024
fae65ed
removing unused;
Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/router/sorClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,12 +537,8 @@ function iterateSwapAmountsApproximation(
// 1.042818e-12 while using normal js math operations it was
// 1.0428184989387553e-12. This loss of precision caused an important bug

// let weighted_average_SPaS = sumSPaSDividedByDerivativeSPaSs.div(
// sumInverseDerivativeSPaSs
// );
const weighted_average_SPaS = bnum(
sumSPaSDividedByDerivativeSPaSs.toNumber() /
sumInverseDerivativeSPaSs.toNumber()
const weighted_average_SPaS = sumSPaSDividedByDerivativeSPaSs.div(
sumInverseDerivativeSPaSs
);

swapAmounts.forEach((swapAmount, i) => {
Expand Down
Loading