Deployment preparation: Protocol Fee Controller (v2) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Good job @EndymionJkb !
Just a few comments, otherwise LGTM!
v3/tasks/20250214-v3-protocol-fee-controller-v2/artifact/WeightedPool.json
Outdated
Show resolved
Hide resolved
v3/tasks/20250214-v3-protocol-fee-controller-v2/build-info/WeightedPool.json
Outdated
Show resolved
Hide resolved
v3/tasks/20250214-v3-protocol-fee-controller-v2/test/task.fork.ts
Outdated
Show resolved
Hide resolved
v3/tasks/20250214-v3-protocol-fee-controller-v2/test/task.fork.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+123
to
+124
| await feeController.connect(admin).setGlobalProtocolSwapFeePercentage(GLOBAL_SWAP_FEE_PERCENTAGE); | ||
| await feeController.connect(admin).setGlobalProtocolYieldFeePercentage(GLOBAL_YIELD_FEE_PERCENTAGE); |
There was a problem hiding this comment.
Hm, this is a good point.
Not in scope for this PR, but do you think we should do a script to do the controller upgrade + set these settings all in the same call?
There was a problem hiding this comment.
Since they're non-zero and presumably want to be continued, yes that would be more efficient. It could read the previous values and pass them through to the new one, so that we don't need to worry about anything hard-coded changing.
…t need the artifact); move BAL/WETH local; add check for protocol fee values in the pool itself
jubeira
previously approved these changes
Feb 12, 2025
v3/tasks/20250214-v3-protocol-fee-controller-v2/test/task.fork.ts
Outdated
Show resolved
Hide resolved
jubeira
approved these changes
Feb 12, 2025
jubeira
deleted the
deployment-preparation/protocol-fee-controller-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment preparation: Protocol Fee Controller (v2)
build-info: balancer/balancer-v3-monorepo@0c38dc6 (includes pool registration initial fee events).
Deployment preparation tasks checklist:
READMEis updated with the new task name and linkREADMEhas a description and links to the artifactsbuild-infois updated with artifacts compiled at the specified commitbuild-infoCode checklist:
master, or there's a description of how to mergeIssue Resolution
Resolves #166