Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminationGracePeriodSeconds #212

Merged
merged 7 commits into from
May 8, 2024
Merged

Add terminationGracePeriodSeconds #212

merged 7 commits into from
May 8, 2024

Conversation

vostres
Copy link
Contributor

@vostres vostres commented Apr 30, 2024

No description provided.

@vostres vostres requested a review from philipp94831 April 30, 2024 12:11
@vostres vostres self-assigned this Apr 30, 2024
philipp94831
philipp94831 requested changes Apr 30, 2024
View reviewed changes
charts/streams-app/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/streams-app/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/streams-app/templates/deployment.yaml Show resolved Hide resolved
@philipp94831
Copy link
Member

Please merge master

@philipp94831
Copy link
Member

Please add podAnnotations/podLabels also to producer-app, producer-app-clean-up-job, streams-app-clean-up-job

@vostres
Copy link
Contributor Author

vostres commented May 2, 2024 •
edited
Loading

Please add podAnnotations/podLabels also to producer-app, producer-app-clean-up-job, streams-app-clean-up-job

@philipp94831 so in case there are already Values.annotations/Values.labels in chart under spec.template.metadata I should just refactor those and if there are none (as in producer-app) add them?

@philipp94831
Copy link
Member

Yeah, would be good to have proper annotation son producer app jobs/cronjobs

@philipp94831
Copy link
Member

We should split the PR in two: one for terminationGracePeriod, one for labels/annotations

@vostres
Copy link
Contributor Author

vostres commented May 7, 2024

We should split the PR in two: one for terminationGracePeriod, one for labels/annotations

I guess I than close this pull request and create two new ones?

@philipp94831
Copy link
Member

We should split the PR in two: one for terminationGracePeriod, one for labels/annotations

I guess I than close this pull request and create two new ones?

Just open one new one. You can use this one for one of the two things

philipp94831
philipp94831 requested changes May 7, 2024
View reviewed changes
Copy link
Member

@philipp94831 philipp94831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README of the chart

@vostres vostres changed the title Add terminationGracePeriodSeconds, podAnnotations, podLabels Add terminationGracePeriodSeconds May 7, 2024
@vostres vostres merged commit 98d75cf into master May 8, 2024
16 checks passed
@vostres vostres deleted the feature/terminationGracePeriodSeconds branch May 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp94831 philipp94831 philipp94831 approved these changes

Assignees

@vostres vostres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vostres @philipp94831