diff --git a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaApplication.java b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaApplication.java index 7162d6fa..ecd239e1 100644 --- a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaApplication.java +++ b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaApplication.java @@ -146,7 +146,7 @@ public void close() { /** * Stop all applications that have been started by {@link #run()}. */ - public void stop() { + public final void stop() { this.runningApps.forEach(RunningApp::close); } @@ -177,7 +177,7 @@ protected void configureDebug() { * initialization of expensive resources. * @return {@code ExecutableApp} */ - protected ExecutableApp createExecutableApp(final boolean cleanUp) { + final ExecutableApp createExecutableApp(final boolean cleanUp) { final ConfiguredApp> configuredStreamsApp = this.createConfiguredApp(cleanUp); final KafkaEndpointConfig endpointConfig = this.getEndpointConfig(); @@ -190,14 +190,14 @@ protected ExecutableApp createExecutableApp(final boolean cleanUp) { * to skip initialization of expensive resources. * @return {@code ConfiguredApp} */ - protected abstract ConfiguredApp> createConfiguredApp(boolean cleanUp); + abstract ConfiguredApp> createConfiguredApp(boolean cleanUp); /** * Create options for running the app * @return run options * @see ExecutableApp#createRunner(Object) */ - protected abstract O createExecutionOptions(); + abstract O createExecutionOptions(); private KafkaEndpointConfig getEndpointConfig() { return KafkaEndpointConfig.builder() diff --git a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaProducerApplication.java b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaProducerApplication.java index 512ee2dd..fa787a7c 100644 --- a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaProducerApplication.java +++ b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaProducerApplication.java @@ -72,12 +72,12 @@ public void clean() { protected abstract ProducerApp createApp(boolean cleanUp); @Override - protected ProducerExecutionOptions createExecutionOptions() { + final ProducerExecutionOptions createExecutionOptions() { return ProducerExecutionOptions.builder().build(); } @Override - protected ConfiguredProducerApp createConfiguredApp(final boolean cleanUp) { + final ConfiguredProducerApp createConfiguredApp(final boolean cleanUp) { final ProducerApp producerApp = this.createApp(cleanUp); final ProducerAppConfiguration configuration = this.createConfiguration(); return new ConfiguredProducerApp<>(producerApp, configuration); diff --git a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java index 5ffd02e3..077ee627 100644 --- a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java +++ b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java @@ -80,7 +80,6 @@ public abstract class KafkaStreamsApplication private boolean volatileGroupInstanceId; /** - * * @see StreamsRunner#run() */ @Override @@ -149,7 +148,7 @@ protected void onStreamsStart(final KafkaStreams streams) { } @Override - protected StreamsExecutionOptions createExecutionOptions() { + final StreamsExecutionOptions createExecutionOptions() { return StreamsExecutionOptions.builder() .volatileGroupInstanceId(this.volatileGroupInstanceId) .uncaughtExceptionHandler(this::createUncaughtExceptionHandler) @@ -159,7 +158,7 @@ protected StreamsExecutionOptions createExecutionOptions() { } @Override - protected ConfiguredStreamsApp createConfiguredApp(final boolean cleanUp) { + final ConfiguredStreamsApp createConfiguredApp(final boolean cleanUp) { final StreamsApp streamsApp = this.createApp(cleanUp); final StreamsAppConfiguration streamsAppConfiguration = this.createConfiguration(); return new ConfiguredStreamsApp<>(streamsApp, streamsAppConfiguration);