Create v3

bakdata · Apr 5, 2024 · ff7a2a0 · ff7a2a0
1 parent e6a1581
commit ff7a2a0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaApplication.java b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaApplication.java
@@ -146,7 +146,7 @@ public void close() {
     /**
      * Stop all applications that have been started by {@link #run()}.
      */
-    public void stop() {
+    public final void stop() {
         this.runningApps.forEach(RunningApp::close);
     }
 
@@ -177,7 +177,7 @@ protected void configureDebug() {
      * initialization of expensive resources.
      * @return {@code ExecutableApp}
      */
-    protected ExecutableApp<R, C, O> createExecutableApp(final boolean cleanUp) {
+    final ExecutableApp<R, C, O> createExecutableApp(final boolean cleanUp) {
         final ConfiguredApp<? extends ExecutableApp<R, C, O>> configuredStreamsApp =
                 this.createConfiguredApp(cleanUp);
         final KafkaEndpointConfig endpointConfig = this.getEndpointConfig();
@@ -190,14 +190,14 @@ protected ExecutableApp<R, C, O> createExecutableApp(final boolean cleanUp) {
      * to skip initialization of expensive resources.
      * @return {@code ConfiguredApp}
      */
-    protected abstract ConfiguredApp<? extends ExecutableApp<R, C, O>> createConfiguredApp(boolean cleanUp);
+    abstract ConfiguredApp<? extends ExecutableApp<R, C, O>> createConfiguredApp(boolean cleanUp);
 
     /**
      * Create options for running the app
      * @return run options
      * @see ExecutableApp#createRunner(Object)
      */
-    protected abstract O createExecutionOptions();
+    abstract O createExecutionOptions();
 
     private KafkaEndpointConfig getEndpointConfig() {
         return KafkaEndpointConfig.builder()

diff --git a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaProducerApplication.java b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaProducerApplication.java
@@ -72,12 +72,12 @@ public void clean() {
     protected abstract ProducerApp createApp(boolean cleanUp);
 
     @Override
-    protected ProducerExecutionOptions createExecutionOptions() {
+    final ProducerExecutionOptions createExecutionOptions() {
         return ProducerExecutionOptions.builder().build();
     }
 
     @Override
-    protected ConfiguredProducerApp<ProducerApp> createConfiguredApp(final boolean cleanUp) {
+    final ConfiguredProducerApp<ProducerApp> createConfiguredApp(final boolean cleanUp) {
         final ProducerApp producerApp = this.createApp(cleanUp);
         final ProducerAppConfiguration configuration = this.createConfiguration();
         return new ConfiguredProducerApp<>(producerApp, configuration);

diff --git a/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java b/streams-bootstrap-picocli/src/main/java/com/bakdata/kafka/KafkaStreamsApplication.java
@@ -80,7 +80,6 @@ public abstract class KafkaStreamsApplication
     private boolean volatileGroupInstanceId;
 
     /**
-     *
      * @see StreamsRunner#run()
      */
     @Override
@@ -149,7 +148,7 @@ protected void onStreamsStart(final KafkaStreams streams) {
     }
 
     @Override
-    protected StreamsExecutionOptions createExecutionOptions() {
+    final StreamsExecutionOptions createExecutionOptions() {
         return StreamsExecutionOptions.builder()
                 .volatileGroupInstanceId(this.volatileGroupInstanceId)
                 .uncaughtExceptionHandler(this::createUncaughtExceptionHandler)
@@ -159,7 +158,7 @@ protected StreamsExecutionOptions createExecutionOptions() {
     }
 
     @Override
-    protected ConfiguredStreamsApp<StreamsApp> createConfiguredApp(final boolean cleanUp) {
+    final ConfiguredStreamsApp<StreamsApp> createConfiguredApp(final boolean cleanUp) {
         final StreamsApp streamsApp = this.createApp(cleanUp);
         final StreamsAppConfiguration streamsAppConfiguration = this.createConfiguration();
         return new ConfiguredStreamsApp<>(streamsApp, streamsAppConfiguration);