Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streams-bootstrap): allow float values in command line #593

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat(streams-bootstrap): allow float values in command line #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8482f7
feat(streams-bootstrap): allow float values in command line
disrupted Jan 16, 2025
bab14c7
test: expand coverage and update snapshots
disrupted Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/docs/schema/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,6 +1585,9 @@
},
{
"type": "integer"
},
{
"type": "number"
}
]
},
Expand Down Expand Up @@ -2712,6 +2715,9 @@
},
{
"type": "integer"
},
{
"type": "number"
}
]
},
Expand Down Expand Up @@ -3329,6 +3335,9 @@
},
{
"type": "integer"
},
{
"type": "number"
}
]
},
Expand Down
6 changes: 6 additions & 0 deletions docs/docs/schema/pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,9 @@
},
{
"type": "integer"
},
{
"type": "number"
}
]
},
Expand Down Expand Up @@ -2384,6 +2387,9 @@
},
{
"type": "integer"
},
{
"type": "number"
}
]
},
Expand Down
2 changes: 1 addition & 1 deletion kpops/components/streams_bootstrap/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class StreamsBootstrapValues(SerializeAsOptionalModel, HelmAppValues):
description=describe_attr("configuration_env_prefix", __doc__),
)

command_line: SerializeAsOptional[dict[str, str | bool | int]] = Field(
command_line: SerializeAsOptional[dict[str, str | bool | int | float]] = Field(
default={},
description=describe_attr("command_line", __doc__),
)
Expand Down
5 changes: 4 additions & 1 deletion tests/pipeline/resources/streams-bootstrap/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
image: "my-registry/my-producer-image"
imageTag: "1.0.0"
commandLine:
FAKE_ARG: "fake-arg-value"
STR: "fake-arg-value"
BOOL: true
INT: 1
FLOAT: 0.1
schedule: "30 3/8 * * *"

to:
Expand Down
10 changes: 8 additions & 2 deletions tests/pipeline/snapshots/test_generate/test_streams_bootstrap/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
type: producer-app-cleaner
values:
commandLine:
FAKE_ARG: fake-arg-value
BOOL: true
FLOAT: 0.1
INT: 1
STR: fake-arg-value
files:
log4j2.xml:
content: |
Expand Down Expand Up @@ -60,7 +63,10 @@
type: my-producer-app
values:
commandLine:
FAKE_ARG: fake-arg-value
BOOL: true
FLOAT: 0.1
INT: 1
STR: fake-arg-value
files:
log4j2.xml:
content: |
Expand Down
8 changes: 7 additions & 1 deletion tests/pipeline/snapshots/test_manifest/test_streams_bootstrap/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@ spec:
value: my-producer-app-output-topic
- name: APP_LABELED_OUTPUT_TOPICS
value: my-producer-app-output-topic-label=my-labeled-producer-app-topic-output,
- name: APP_FAKE_ARG
- name: APP_BOOL
value: 'true'
- name: APP_FLOAT
value: '0.1'
- name: APP_INT
value: '1'
- name: APP_STR
value: fake-arg-value
- name: JAVA_TOOL_OPTIONS
value: '-XX:MaxRAMPercentage=75.0 '
Expand Down
Loading