Skip to content

Commit

Permalink
fix: Ingress annotations format (#13)
Browse files Browse the repository at this point in the history
  • Loading branch information
tumido authored Dec 8, 2022
1 parent 737ba4f commit 29d69af
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.6.0
version: 0.6.1

dependencies:
- name: common
Expand Down
4 changes: 2 additions & 2 deletions charts/backstage/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
{{- end }}
annotations:
{{- if .Values.ingress.annotations }}
{{ include "common.tplvalues.render" ( dict "value" .Values.ingress.annotations "context" $) | nindent 4 }}
{{- include "common.tplvalues.render" ( dict "value" .Values.ingress.annotations "context" $) | nindent 4 }}
{{- end }}
{{- if .Values.commonAnnotations }}
{{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
Expand All @@ -37,4 +37,4 @@ spec:
name: {{ include "common.names.fullname" . }}
port:
number: {{ .Values.service.ports.backend }}
{{- end }}
{{- end }}
5 changes: 1 addition & 4 deletions charts/backstage/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ ingress:
className: ""

## @param ingress.annotations Additional annotations for the Ingress resource
annotations: '{
"nginx.ingress.kubernetes.io/rewrite-target": "/",
"nginx.ingress.kubernetes.io/ssl-redirect": "false"
}'
annotations: {}

## @param host Hostname to be used to expose the route to access the backstage application (e.g: backstage.IP.nip.io)
host: ""
Expand Down

0 comments on commit 29d69af

Please sign in to comment.