From 1c02855d61962fd386db8d5644223cca0d1f5048 Mon Sep 17 00:00:00 2001 From: Alex Eftimie Date: Fri, 27 Jan 2023 14:20:54 +0100 Subject: [PATCH] fix: declare both appConfig and resources (#56) --- charts/backstage/Chart.yaml | 2 +- charts/backstage/README.md | 2 +- charts/backstage/templates/backstage-deployment.yaml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/charts/backstage/Chart.yaml b/charts/backstage/Chart.yaml index e535b53..a852df0 100644 --- a/charts/backstage/Chart.yaml +++ b/charts/backstage/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.15.0 +version: 0.15.1 dependencies: - name: common diff --git a/charts/backstage/README.md b/charts/backstage/README.md index f3c35b4..c59bf81 100644 --- a/charts/backstage/README.md +++ b/charts/backstage/README.md @@ -1,7 +1,7 @@ # Backstage Helm Chart -![Version: 0.15.0](https://img.shields.io/badge/Version-0.15.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) +![Version: 0.15.1](https://img.shields.io/badge/Version-0.15.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) A Helm chart for deploying a Backstage application diff --git a/charts/backstage/templates/backstage-deployment.yaml b/charts/backstage/templates/backstage-deployment.yaml index 924d6fa..a3cfa91 100644 --- a/charts/backstage/templates/backstage-deployment.yaml +++ b/charts/backstage/templates/backstage-deployment.yaml @@ -86,9 +86,6 @@ spec: {{- range .Values.backstage.args }} - {{ . | quote }} {{- end }} - {{- if .Values.backstage.resources }} - resources: {{- include "common.tplvalues.render" (dict "value" .Values.backstage.resources "context" $) | nindent 12 }} - {{- end }} {{- if .Values.backstage.extraAppConfig }} {{- range .Values.backstage.extraAppConfig }} - "--config" @@ -100,6 +97,9 @@ spec: - "app-config-from-configmap.yaml" {{- end }} {{- end }} + {{- if .Values.backstage.resources }} + resources: {{- include "common.tplvalues.render" (dict "value" .Values.backstage.resources "context" $) | nindent 12 }} + {{- end }} {{- if .Values.backstage.extraEnvVarsSecrets }} envFrom: {{- range .Values.backstage.extraEnvVarsSecrets }}