Add support for value variables '@value' and fix default exports #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0skar
changed the title
r0skar
changed the title
babakness
reviewed
Apr 30, 2019
| @@ -16,7 +16,7 @@ program | |||
| .version(version) | |||
| .usage('[options]') | |||
| .option('-b, --base <path>', `default base is ${ defaults.base }`) | |||
| .option('-i, --sass-include <paths>', `list of paths to includedefault is ${ defaults.sassInclude }`) | |||
babakness
reviewed
Apr 30, 2019
| @@ -31,10 +31,11 @@ const toCamelCase = ( str: string ) => str.replace(/-+(\w)/g, ( _match, firstLet | |||
|
|
|||
| const getDtsContent = async ( sassInclude: string[], sassData: string, includeIndexKey: boolean, path: string ) => { | |||
| try { | |||
| const fileData = fs.readFileSync(path, 'utf-8') | |||
There was a problem hiding this comment.
I would prefer a non-blocking solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive approach to add support for value variables. I dont expect the PR to be merged as-is, but I hope this will start a conversation for proper support for
@valueand eventually the:exportselector.Additionally, I fixed the
The expression of an export assignment must be an identifier or qualified name in an ambient context.the default export declaration.