Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-6322] refactor: add new properties for identify tracking #2201

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

HerbertJulio
Copy link
Collaborator

Pull Request

What is the new behavior introduced by this PR?

This pull request includes changes to the src/App.vue file to enhance the tracking of account information by adding more detailed traits. The most important changes are:

  • Expanded the destructuring assignment of accountStore.account to include company_name, kind, full_name, and status.
  • Updated the defaultTraits object to include additional properties: client_name, account_company_name, account_name, account_type, and client_status.

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

image

Does it have a link on Figma?

NO


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari
  • Brave

@HerbertJulio HerbertJulio added the code-refactor A tag for Pull Requests focusing on code refactoring, improving code structure, readability, and mai label Feb 19, 2025
@HerbertJulio HerbertJulio self-assigned this Feb 19, 2025
@HerbertJulio HerbertJulio requested review from a team as code owners February 19, 2025 23:41
@HerbertJulio HerbertJulio changed the title [UXE-6322] refactor: add new properties for ID tracking [UXE-6322] refactor: add new properties for identify tracking Feb 19, 2025
vinigfer
vinigfer previously approved these changes Feb 20, 2025
Copy link
Member

@vinigfer vinigfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's a feat instead of refactor

pauloSF0
pauloSF0 previously approved these changes Feb 20, 2025
@HerbertJulio HerbertJulio dismissed stale reviews from pauloSF0 and vinigfer via 8d08391 February 21, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-refactor A tag for Pull Requests focusing on code refactoring, improving code structure, readability, and mai
Development

Successfully merging this pull request may close these issues.

3 participants