Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-6402] feat: implement banner visibility logic based on FORCE_REDIRECT_TO_CONSOLE flag #2181

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

HerbertJulio
Copy link
Collaborator

Pull Request

What is the new behavior introduced by this PR?

This pull request includes changes to the src/stores/account.js and src/views/Home/HomeView.vue files. The main focus of these changes is to introduce a new feature flag and utilize it to control the visibility of a banner on the home view.

Feature flag additions and usage:

  • src/stores/account.js: Added a new feature flag FORCE_REDIRECT_TO_CONSOLE to the flags object and implemented a new getter isBannerVisible to determine the visibility of a banner based on this flag. [1] [2]

Home view modifications:

  • src/views/Home/HomeView.vue: Updated the usage of useAccountStore to include the isBannerVisible getter and conditionally rendered the InlineMessage component based on the value of isBannerVisible. [1] [2]

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

NO

Does it have a link on Figma?

NO


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari
  • Brave

@HerbertJulio HerbertJulio added the enhancement New feature or request label Feb 17, 2025
@HerbertJulio HerbertJulio self-assigned this Feb 17, 2025
@HerbertJulio HerbertJulio requested review from a team as code owners February 17, 2025 18:15
@HerbertJulio HerbertJulio changed the title [UXE-6402] feat: add banner display logic based on FORCE_REDIRECT_TO_CONSOLE flag [UXE-6402] feat: implement banner visibility logic based on FORCE_REDIRECT_TO_CONSOLE flag Feb 17, 2025
@HerbertJulio HerbertJulio merged commit 369bc00 into dev Feb 17, 2025
10 of 14 checks passed
@HerbertJulio HerbertJulio deleted the remover-banner branch February 17, 2025 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants