Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UXE-4301] fix: show the message about deleting a payment method correctly #1540

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[UXE-4301] fix: show the message about deleting a payment method correctly #1540

merged 2 commits into from
Jul 29, 2024

Conversation

peterpaulo-azion
Copy link
Contributor

Bug fix

Explain what was fixed and the correct behavior.

  • showing the response API message

Does this PR introduce UI changes? Add a video or screenshots here.

image

Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] bug: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • New tests are added to prevent the same issue from happening again
  • UI changes are validated by a team designer
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@peterpaulo-azion peterpaulo-azion added the bug Something isn't working label Jul 26, 2024
@peterpaulo-azion peterpaulo-azion self-assigned this Jul 26, 2024
@peterpaulo-azion peterpaulo-azion requested review from a team as code owners July 26, 2024 18:06
william-tome
william-tome reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@william-tome william-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor, coloca o link da execução manual do teste e2e do billing, pois ele não roda no fluxo principal

@peterpaulo-azion
Copy link
Contributor Author

https://github.com/aziontech/azion-console-kit/actions/runs/10115932692

Workflow de testes

@peterpaulo-azion peterpaulo-azion merged commit 3e3c31d into dev Jul 29, 2024
4 checks passed
@peterpaulo-azion peterpaulo-azion deleted the fix-show-payment-response-message-correctly branch July 29, 2024 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@william-tome william-tome william-tome approved these changes

@matheus-sunderhus matheus-sunderhus matheus-sunderhus approved these changes

Assignees

@peterpaulo-azion peterpaulo-azion

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterpaulo-azion @william-tome @matheus-sunderhus