Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting BSE #2

Open
azadoks opened this issue Sep 21, 2021 · 1 comment
Open

Supporting BSE #2

azadoks opened this issue Sep 21, 2021 · 1 comment

Comments

@azadoks
Copy link
Owner

azadoks commented Sep 21, 2021

Currently, BasisSets are represented and stored by aiida-basis as SingleFileDatas in AiiDA.
This implementation makes sense for numerical orbitals like OpenMX's PAOs because

  1. The basis is used in practice as a single file per element
  2. There is a single file-format for the basis
  3. The contents of the basis don't need to be modified

However, this is not true in general.
Specifically, to support basis sets from the Basis Set Exchange, this architecture needs to be rethought.

I've opened this issue as a place to discuss what a more general implementation would look like.

@azadoks
Copy link
Owner Author

azadoks commented Sep 21, 2021

My naïve suggestion would be to:

  • Rename BasisData to BasisFileData; it will be used to represent/store file-based bases (one element per basis)
  • Create a new base class BasisData used for storing the data (not file) of a basis (one element per basis)
  • Modify BasisSet to support both BasisFileData types and BasisData types

Another note is on nomenclature, currently I am calling a basis set which corresponds to a element/species a "basis" while a collection of basis sets, e.g. STO-3G for all available elements/species, a "basis set".
As I don't have much experience with how these things are called in the community, perhaps this should be changed.
Does it make more sense to call the data for a single element a "basis set" and the data for a collection of elements a "basis set family"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant