Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GitHub action(s) usage #260

Open
axel3rd opened this issue Aug 30, 2023 · 1 comment
Open

Remove deprecated GitHub action(s) usage #260

axel3rd opened this issue Aug 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@axel3rd
Copy link
Owner

axel3rd commented Aug 30, 2023

From https://github.com/axel3rd/mpg-coach-bot/actions/runs/6029845209 we can see that:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/create-release@v1, actions/upload-release-asset@v1

Both actions generate some:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files

So deprecated actions should be replaced: actions/create-release@v1 + actions/upload-release-asset@v1

- name: Create Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: ${{ env.package_name }}
draft: false
prerelease: false
- name: Upload Release Asset
id: upload_release_asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./target/${{ env.package_name }}
asset_name: ${{ env.package_name }}
asset_content_type: application/jar

@axel3rd axel3rd added the enhancement New feature or request label Aug 30, 2023
@axel3rd
Copy link
Owner Author

axel3rd commented Aug 30, 2023

Probable best orientation: Merge both in one with softprops/action-gh-release.

@axel3rd axel3rd changed the title Remove deprecated action(s) usage Remove deprecated GitHub action(s) usage Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant