Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple divisions support with new mobile API #193

Open
axel3rd opened this issue Aug 11, 2021 · 1 comment
Open

Multiple divisions support with new mobile API #193

axel3rd opened this issue Aug 11, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed postponed Feature or fix not implementable in short terms

Comments

@axel3rd
Copy link
Owner

axel3rd commented Aug 11, 2021

With new MPG APIs from mobile app usage (#191), the multiple division support (#129) was removed ; because APIs have completely change and I haven't this MPG use case.

Some data for unit tests are necessary (see here).

At minimum, the /dashboard/leagues content, like explained in Get MPG data for opening a bug.

@axel3rd axel3rd added enhancement New feature or request help wanted Extra attention is needed labels Aug 11, 2021
@axel3rd
Copy link
Owner Author

axel3rd commented Aug 11, 2021

FI, it was managed like that:

static void process(ApiClients apiClients, Config config) {
for (League leagueOptionalMaster : apiClients.getMpg().getDashboard().getLeagues()) {
League league = leagueOptionalMaster;
if (league.isMasterLeague()) {
league = league.getSubLeague();
}

@axel3rd axel3rd added the postponed Feature or fix not implementable in short terms label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed postponed Feature or fix not implementable in short terms
Projects
None yet
Development

No branches or pull requests

1 participant