Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redirect invalid workspace name to the last visited workspace #122

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

jessieweiyi
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR is to:

  • Redirect initial url including invalid workspace name to the last visited workspace
  • Hide Preview button in the IDE-Extension mode since the Preview is open in another tab which is not supported in IDE
  • Set Constraint on workspace name so that it will not cause routing issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi requested a review from dboyd13 June 21, 2024 05:16
Copy link
Contributor

@dboyd13 dboyd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dboyd13 dboyd13 merged commit 384ae90 into main Jun 23, 2024
2 checks passed
@dboyd13 dboyd13 deleted the fix/workspace-invalid-name-routing branch June 23, 2024 23:02
Copy link

🎉 This PR is included in version 1.0.51 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants