Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support download the model as DOCX file #116

Merged
merged 4 commits into from
Jun 12, 2024
Merged

feat: Support download the model as DOCX file #116

merged 4 commits into from
Jun 12, 2024

Conversation

jessieweiyi
Copy link
Contributor

Issue #, if available:

Description of changes:

Support downloading of the threat model as DOCX file in the Threat Model View page.

Limitations:

  • External images cannot be fetched due to browser security constraints so it is unable to get the blob of the file.
    Currently, the external image is shown in browser in the tag as a native browser support. In the DOCX file, the external image is rendered as an image unavailable place holder with external hyper link to allow users to click on the image to browser the image in the browser.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi requested a review from dboyd13 June 7, 2024 08:00
Copy link
Contributor

@dboyd13 dboyd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dboyd13 dboyd13 merged commit 24b4b91 into main Jun 12, 2024
2 checks passed
@dboyd13 dboyd13 deleted the feat/docx branch June 12, 2024 20:53
Copy link

🎉 This PR is included in version 1.0.47 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

maxneuvians added a commit to maxneuvians/threat-composer that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants