Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix bytecode cache index generation error #855

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

nabetti1720
Copy link
Contributor

Issue # (if available)

fix #846

Description of changes

There was an error in the index generation process for the bytecode cache.
Specifically, the index was generated in a format different from the chunk file name written in the code (specifically, the extension was missing), which caused a resolution error.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison
Copy link
Collaborator

Nice finding. Thank you!

@richarddavison richarddavison merged commit 6b87efe into awslabs:main Mar 3, 2025
11 checks passed
@nabetti1720 nabetti1720 deleted the fix/bytecode-cache-index branch March 3, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: Error resolving module '../llrt-loadSts-sdk-RSYFFQRI.js' from '@aws-sdk/credential-providers
2 participants