Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix incompatibilities caused by the latest cargo fix #847

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

nabetti1720
Copy link
Contributor

Description of changes

After applying the latest rust toolchain, we found new incompatibilities and have fixed them.

% rustup update
info: syncing channel updates for 'stable-aarch64-apple-darwin'
info: syncing channel updates for 'nightly-aarch64-apple-darwin'
info: checking for self-update

   stable-aarch64-apple-darwin unchanged - rustc 1.85.0 (4d91de4e4 2025-02-17)
  nightly-aarch64-apple-darwin unchanged - rustc 1.87.0-nightly (f04bbc60f 2025-02-20)

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison
Copy link
Collaborator

Thanks! LGTM!

@richarddavison richarddavison self-requested a review February 23, 2025 18:43
@richarddavison richarddavison merged commit ec1dd3b into awslabs:main Feb 23, 2025
11 checks passed
@nabetti1720 nabetti1720 deleted the fix/cargo-fix branch February 23, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants