Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: add chmodSync #835

Merged
merged 4 commits into from
Feb 13, 2025
Merged

fs: add chmodSync #835

merged 4 commits into from
Feb 13, 2025

Conversation

ahaoboy
Copy link
Contributor

@ahaoboy ahaoboy commented Feb 10, 2025

Issue # (if available)

close: #828

Description of changes

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison
Copy link
Collaborator

Thanks for the PR. Some minor comments :)

@richarddavison richarddavison merged commit b4735e0 into awslabs:main Feb 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support fs.chmod and fs.chmodSync
3 participants