GlobalConfig: Toggling controlTower.landingZone.logging.organizationTrail does not update the ControlTower landing zone

[florian-netlight]

Describe the bug
Updating the configuration controlTower.landingZone.logging.organizationTrail in the global config does not effect the ControlTower landing zone. It is not updated and gets out of sync.

To Reproduce

• Deploy the LZA with the following segment in global-config.yaml

controlTower:
enable: true
landingZone:
  version: '3.3'
  logging:
    loggingBucketRetentionDays: 365
    accessLoggingBucketRetentionDays: 365
    organizationTrail: true

• Deploy the LZA with the following segment in global-config.yaml

controlTower:
enable: true
landingZone:
  version: '3.3'
  logging:
    loggingBucketRetentionDays: 365
    accessLoggingBucketRetentionDays: 365
    organizationTrail: false

Expected behavior
ControlTower landing zone is updated

Please complete the following information about the solution:

• Version: v1.11.0
• Region: eu-west-1
• Was the solution modified from the version published on this repository? No
• If the answer to the previous question was yes, are the changes available on GitHub? Not relevant
• Have you checked your service quotas for the services this solution uses? Not relevant
• Were there any errors in the CloudWatch Logs? Not relevant

[florian-netlight]

When browsing through the code, I found out that there is one condition not checked which leads to this issue.
#704 should fix it.

The fix is to be verified.

[Athanasii]

Thank you for raising this issue. We are looking into it.

[richardkeit]

Hello @Athanasii ,

Please find a related issue raised against the TSE codebase that should be considered - aws-samples/landing-zone-accelerator-on-aws-for-tse-se#13