Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: New warning in v1.11 #681

Open
5 of 6 tasks
mbevc1 opened this issue Dec 17, 2024 · 2 comments
Open
5 of 6 tasks

bug: New warning in v1.11 #681

mbevc1 opened this issue Dec 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mbevc1
Copy link

mbevc1 commented Dec 17, 2024

Describe the bug
Seems there are new warnings compiling v1.11.0

#11 269.8 @aws-accelerator/tools: 
#11 269.8 @aws-accelerator/tools: <span class='ace_invisible ace_invisible_space ace_invalid'>·</span>[1G@aws-accelerator/tools: 
#11 269.8 @aws-accelerator/tools: $ tsc
#11 269.8 @aws-accelerator/constructs: 
#11 269.8 @aws-accelerator/constructs: <span class='ace_invisible ace_invisible_space ace_invalid'>·</span>[1G@aws-accelerator/constructs: $ tsc
#11 269.8 @aws-accelerator/load-config-table: 
#11 269.8 @aws-accelerator/load-config-table: <span class='ace_invisible ace_invisible_space ace_invalid'>·</span>[1G@aws-accelerator/load-config-table: 
#11 269.8 @aws-accelerator/load-config-table: $ esbuild --minify --bundle --sourcemap --platform=node --target=node18 --outfile=./dist/index.js index.ts
#11 269.8 @aws-accelerator/lza-modules: 
#11 269.8 @aws-accelerator/lza-modules: <span class='ace_invisible ace_invisible_space ace_invalid'>·</span>[1G@aws-accelerator/lza-modules: 
#11 269.8 @aws-accelerator/lza-modules: $ tsc
#11 270.0 @aws-accelerator/load-config-table: ▲ [WARNING] The "??" operator here will always return the left operand [suspicious-nullish-coalescing]
#11 270.0 @aws-accelerator/load-config-table:     ../../../../config/validator/accounts-config-validator.ts:164:84:
#11 270.0 @aws-accelerator/load-config-table:       164 │ ......values.mandatoryAccounts, ...values.workloadAccounts] ?? []) {
#11 270.0 @aws-accelerator/load-config-table:           ╵                                                             ~~
#11 270.0 @aws-accelerator/load-config-table:   The left operand of the "??" operator here will never be null or undefined, so it will always be returned. This usually indicates a bug in your code:
#11 270.0 @aws-accelerator/load-config-table:     ../../../../config/validator/accounts-config-validator.ts:164:26:
#11 270.0 @aws-accelerator/load-config-table:       164 │ ...ccount of [...values.mandatoryAccounts, ...values.workloadAcco...
#11 270.0 @aws-accelerator/load-config-table:           ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#11 270.2 @aws-accelerator/load-config-table: ▲ [WARNING] The "??" operator here will always return the left operand [suspicious-nullish-coalescing]
#11 270.2 @aws-accelerator/load-config-table:     ../../../../config/validator/network-config-validator/network-firewall-validator.ts:298:86:
#11 270.2 @aws-accelerator/load-config-table:       298 │ ...ibutes.sources ?? []), ...(attributes.destinations ?? [])] ?? [];
#11 270.2 @aws-accelerator/load-config-table:           ╵                                                               ~~
#11 270.2 @aws-accelerator/load-config-table:   The left operand of the "??" operator here will never be null or undefined, so it will always be returned. This usually indicates a bug in your code:
#11 270.2 @aws-accelerator/load-config-table:     ../../../../config/validator/network-config-validator/network-firewall-validator.ts:298:18:
#11 270.2 @aws-accelerator/load-config-table:       298 │ ...t cidrs = [...(attributes.sources ?? []), ...(attributes.desti...
#11 270.2 @aws-accelerator/load-config-table:           ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#11 270.2 @aws-accelerator/load-config-table: ▲ [WARNING] The "??" operator here will always return the left operand [suspicious-nullish-coalescing]
#11 270.2 @aws-accelerator/load-config-table:     ../../../../config/validator/network-config-validator/network-firewall-validator.ts:349:99:
#11 270.2 @aws-accelerator/load-config-table:       349 │ ...estinationPorts ?? []), ...(attributes.sourcePorts ?? [])] ?? [];
#11 270.2 @aws-accelerator/load-config-table:           ╵                                                               ~~
#11 270.2 @aws-accelerator/load-config-table:   The left operand of the "??" operator here will never be null or undefined, so it will always be returned. This usually indicates a bug in your code:
#11 270.2 @aws-accelerator/load-config-table:     ../../../../config/validator/network-config-validator/network-firewall-validator.ts:349:23:
#11 270.2 @aws-accelerator/load-config-table:       349 │ ...tRanges = [...(attributes.destinationPorts ?? []), ...(attribu...
#11 270.2 @aws-accelerator/load-config-table:           ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#11 280.8 @aws-accelerator/load-config-table: 3 warnings
#11 280.8 @aws-accelerator/load-config-table:   dist/index.js      34.8mb ⚠️
#11 280.8 @aws-accelerator/load-config-table:   dist/index.js.map  96.4mb

To Reproduce
Transpile LZA

Expected behavior
Warning free

Please complete the following information about the solution:

  • Version: [e.g. v1.11.0]

To get the version of the solution, you can look at the description of the created AWS CloudFormation stack used to install the LZA (AWSAccelerator-InstallerStack). For example, "(SO0199) Landing Zone Accelerator on AWS. Version 1.5.1.". If the description does not contain the version information, you can look at the Parameters of the stack for the RepositoryBranchName as that should contain the version number.

  • Region: [e.g. eu-west-1]
  • Was the solution modified from the version published on this repository? No
  • If the answer to the previous question was yes, are the changes available on GitHub?
  • Have you checked your service quotas for the services this solution uses?
  • Were there any errors in the CloudWatch Logs?

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

n/a

@mbevc1 mbevc1 added the bug Something isn't working label Dec 17, 2024
@Athanasii
Copy link
Contributor

Hello @mbevc1 , thank you for filing an issue with the Landing Zone Accelerator team! We are currently looking into the issue you've reported and will provide a status update as soon as possible.

@mbevc1
Copy link
Author

mbevc1 commented Feb 6, 2025

Thanks @Athanasii 👍 . Looking forward to hearing back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants