Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration guide for aws-smithy-client #952

Closed
cetanu opened this issue Nov 13, 2023 · 7 comments
Closed

migration guide for aws-smithy-client #952

cetanu opened this issue Nov 13, 2023 · 7 comments
Labels
documentation This is a problem with documentation

Comments

@cetanu
Copy link

cetanu commented Nov 13, 2023

Describe the issue

I'm updating some dependencies for an open-source project and they are using aws-smithy-client.

When I browse the docs for this crate, it shows that the crate is now empty and was deprecated some time ago.
However, I cannot find a corresponding guide for migrating away from using this crate.

Can someone point me to such documentation, or an example of how to use some alternative in place of the now-removed crate?

Links

https://docs.rs/aws-smithy-client/latest/aws_smithy_client/

@cetanu cetanu added documentation This is a problem with documentation needs-triage This issue or PR still needs to be triaged. labels Nov 13, 2023
@Velfi
Copy link
Contributor

Velfi commented Nov 13, 2023

What is the open source project trying to do with the client? Could you share a link to it? We have a lot of migration guides at the moment but I think this one is the most relevant.

@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Nov 13, 2023
@jdisanti
Copy link
Contributor

The changelogs for both aws-sdk-rust and smithy-rs should have information on breaking changes:
https://github.com/awslabs/aws-sdk-rust/blob/main/CHANGELOG.md
https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md

@stmcginnis
Copy link

The example code also needs to be updated. It is currently broken with this change.

https://github.com/awslabs/aws-sdk-rust/blob/main/examples/examples/custom-root-certificates/src/main.rs#L7

@jdisanti
Copy link
Contributor

Thanks for letting us know! It looks like it fell out of the Cargo workspace, so it wasn't getting picked up by CI. I filed an issue on the examples repo to fix it: awsdocs/aws-doc-sdk-examples#5668

@cetanu
Copy link
Author

cetanu commented Nov 16, 2023

The project is vector, there are usages such as this throughout the codebase: https://github.com/vectordotdev/vector/blob/master/src/sinks/aws_cloudwatch_logs/config.rs#L36-L50

I'll read through the provided docs and give it a crack at some point

@jmklix
Copy link
Member

jmklix commented Aug 6, 2024

Please checkout the changelogs, or let us know if you have any other specific migration questions

The changelogs for both aws-sdk-rust and smithy-rs should have information on breaking changes: https://github.com/awslabs/aws-sdk-rust/blob/main/CHANGELOG.md https://github.com/smithy-lang/smithy-rs/blob/main/CHANGELOG.md

@jmklix jmklix closed this as completed Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation
Projects
None yet
Development

No branches or pull requests

5 participants