Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC 64 NVME checksum not available for S3 requests. #1219

Closed
1 task
dristic opened this issue Dec 10, 2024 · 4 comments
Closed
1 task

CRC 64 NVME checksum not available for S3 requests. #1219

dristic opened this issue Dec 10, 2024 · 4 comments
Labels
p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet. s3 service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@dristic
Copy link

dristic commented Dec 10, 2024

Describe the bug

On the latest SDK there is no function for providing a crc64nvme checksum.

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

From the docs at https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html it mentions you can pass this new checksum algorithm for integrity checking objects.

Current Behavior

The checksum algorithm enum only supplies

Crc32,
Crc32C,
Sha1,
Sha256,

Reproduction Steps

Install 1.65 of aws-sdk-s3 crate.

Possible Solution

No response

Additional Information/Context

Just curious when this might become available since it recently got released.

Version

1.65.0

Environment details (OS name and version, etc.)

Windows 11, rustc 1.82.0 (f6e511eec 2024-10-15)

Logs

No response

@dristic dristic added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2024
@aajtodd
Copy link
Contributor

aajtodd commented Dec 10, 2024

I don't believe this is available quite yet:

Starting on December 1, the CRC-64NVME checksum algorithm and improved checksum integrity features will become available in the coming weeks.

Will update once support has landed.

@aajtodd aajtodd added pending-release This issue will be fixed by an approved PR that hasn't been released yet. service-api This issue is due to a problem in a service API, not the SDK implementation. p2 This is a standard priority issue s3 and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2024
@dristic
Copy link
Author

dristic commented Dec 10, 2024

Ah understood. The wording was a little confusing. Looking forward to giving this a try!

@ysaito1001
Copy link
Collaborator

This is now supported as of yesterday's release.

Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet. s3 service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants