Client expecting ObjectLockRetention when server sends Retention on get_object_retention

[jocutajar]

Describe the bug

I get this error parsing XML: invalid root, expected ObjectLockRetention got StartEl { name: Name { prefix: "", local: "Retention" }, attributes: [Attr { name: Name { prefix: "", local: "xmlns" }, value: "http://s3.amazonaws.com/doc/2006-03-01/" }], closed: false, depth: 0 }

Request:
GET https://s3.us-east-005.backblazeb2.com/some_bucket/some_file_in_bucket?retention

Response:

HTTP/1.1 200 OK
... headers ...

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Retention xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <Mode>GOVERNANCE</Mode>
    <RetainUntilDate>2024-01-01T09:25:13.000Z</RetainUntilDate>
</Retention>

Expected Behavior

I'm not sure if the server or the client got it wrong, but considering this was working previously with rusoto_s3, I would suspect the SDK. So the client should parse the Retention element as given.

Current Behavior

Error parsing XML

Reproduction Steps

get_object_retention where such retention is specified

Possible Solution

No response

Additional Information/Context

No response

Version

aws-sdk-rust/1.1.5 api/s3/1.15.0 os/linux lang/rust/1.76.0


├── aws-sdk-s3 v1.15.0
│   ├── aws-credential-types v1.1.5
│   │   ├── aws-smithy-async v1.1.5
│   │   ├── aws-smithy-runtime-api v1.1.5
│   │   │   ├── aws-smithy-async v1.1.5 (*)
│   │   │   ├── aws-smithy-types v1.1.5
│   │   ├── aws-smithy-types v1.1.5 (*)
│   ├── aws-runtime v1.1.5
│   │   ├── aws-credential-types v1.1.5 (*)
│   │   ├── aws-sigv4 v1.1.5
│   │   │   ├── aws-credential-types v1.1.5 (*)
│   │   │   ├── aws-smithy-eventstream v0.60.4
│   │   │   │   ├── aws-smithy-types v1.1.5 (*)
│   │   │   ├── aws-smithy-http v0.60.5
│   │   │   │   ├── aws-smithy-eventstream v0.60.4 (*)
│   │   │   │   ├── aws-smithy-runtime-api v1.1.5 (*)
│   │   │   │   ├── aws-smithy-types v1.1.5 (*)
│   │   │   ├── aws-smithy-runtime-api v1.1.5 (*)
│   │   │   ├── aws-smithy-types v1.1.5 (*)
│   │   ├── aws-smithy-async v1.1.5 (*)
│   │   ├── aws-smithy-eventstream v0.60.4 (*)
│   │   ├── aws-smithy-http v0.60.5 (*)
│   │   ├── aws-smithy-runtime-api v1.1.5 (*)
│   │   ├── aws-smithy-types v1.1.5 (*)
│   │   ├── aws-types v1.1.5
│   │   │   ├── aws-credential-types v1.1.5 (*)
│   │   │   ├── aws-smithy-async v1.1.5 (*)
│   │   │   ├── aws-smithy-runtime-api v1.1.5 (*)
│   │   │   ├── aws-smithy-types v1.1.5 (*)
│   ├── aws-sigv4 v1.1.5 (*)
│   ├── aws-smithy-async v1.1.5 (*)
│   ├── aws-smithy-checksums v0.60.5
│   │   ├── aws-smithy-http v0.60.5 (*)
│   │   ├── aws-smithy-types v1.1.5 (*)
│   ├── aws-smithy-eventstream v0.60.4 (*)
│   ├── aws-smithy-http v0.60.5 (*)
│   ├── aws-smithy-json v0.60.5
│   │   └── aws-smithy-types v1.1.5 (*)
│   ├── aws-smithy-runtime v1.1.5
│   │   ├── aws-smithy-async v1.1.5 (*)
│   │   ├── aws-smithy-http v0.60.5 (*)
│   │   ├── aws-smithy-runtime-api v1.1.5 (*)
│   │   ├── aws-smithy-types v1.1.5 (*)
│   ├── aws-smithy-runtime-api v1.1.5 (*)
│   ├── aws-smithy-types v1.1.5 (*)
│   ├── aws-smithy-xml v0.60.5
│   ├── aws-types v1.1.5 (*)
├── aws-smithy-runtime-api v1.1.5 (*)

### Environment details (OS name and version, etc.)

debian 12

### Logs

_No response_

[rcoh]

that's for including the raw response! I'll see if I can get a quick fix in for the next release which should be out sometime this week or early next.

[jdisanti]

Working on a fix in smithy-lang/smithy-rs#3492

[rcoh]

Fixed in the most recent S3 release. Thanks for reporting! We found a similar issue with GetObjectLockLegalHold which was also fixed

[github-actions]

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.