fix: enhance smoke test debuggability by echoing build output from inner Gradle runner #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner Gradle runner
ianbotsf
added
the
no-changelog
|
|
A new generated diff is ready to view.
|
Affected ArtifactsNo artifacts changed size |
lauzadis
reviewed
Feb 3, 2025
Comment on lines
-37
to
-38
| assertContains(smokeTestRunnerOutput, "#\tat aws.smithy.kotlin.runtime.http.interceptors.SmokeTestsInterceptor.readBeforeDeserialization(SmokeTestsInterceptor.kt:19)") | ||
| assertContains(smokeTestRunnerOutput, "#\tat aws.smithy.kotlin.runtime.http.interceptors.InterceptorExecutor.readBeforeDeserialization(InterceptorExecutor.kt:252)") |
There was a problem hiding this comment.
Did we lose the stack trace with this change?
There was a problem hiding this comment.
We lost the stack trace assertion with this change. Asserting on stack traces is brittle and adds no value to this test. I'd remove other parts of the exception message assertions as well but that would be a larger refactor so for now I'm just removing this.
lauzadis
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Similar to #1515, enhancing smoke test debuggability by echoing build output from the inner Gradle runner to the outer Gradle process. Because the existing code waits for the inner process to exit before evaluating the output, I think we may be missing logs when the inner process exits abruptly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.