Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3ResponseError.operation_name #530

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add S3ResponseError.operation_name #530

merged 1 commit into from
Nov 22, 2023

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Nov 22, 2023

This hooks up functionality from:
awslabs/aws-c-s3#377

Issue:
If an AWS SDK is using the CRT S3 client, it was difficult to map CRT exceptions to SDK exceptions since it wasn't clear exactly which S3 HTTP request failed (A CRT S3 request might make several HTTP requests under the hood)

Description of changes:

  • Expose operation_name in the S3ResponseError.
  • Also, if user is creating a DEFAULT request (where CRT doesn't know which operation is being performed), the user can pass in the operation_name

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm enabled auto-merge (squash) November 22, 2023 22:56
@graebm graebm merged commit 9c12763 into main Nov 22, 2023
@graebm graebm deleted the s3-operation-name branch November 22, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants