Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support header checksum #454

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Support header checksum #454

merged 8 commits into from
Oct 17, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Oct 7, 2024

Issue #, if available:

  • Adding support for providing checksum in the header instead of trailer.
  • CRT will read the body into memory and calculate the checksum directly from the memory in this case, and add it to the header of the request instead of trailer

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.69%. Comparing base (1670150) to head (8f54ef1).

Files with missing lines Patch % Lines
source/s3_request_messages.c 88.63% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   89.69%   89.69%   -0.01%     
==========================================
  Files          20       20              
  Lines        6145     6172      +27     
==========================================
+ Hits         5512     5536      +24     
- Misses        633      636       +3     
Files with missing lines Coverage Δ
source/s3_client.c 90.31% <ø> (+0.15%) ⬆️
source/s3_request_messages.c 74.77% <88.63%> (+0.85%) ⬆️

... and 1 file with indirect coverage changes

include/aws/s3/s3_client.h Outdated Show resolved Hide resolved
source/s3_request_messages.c Outdated Show resolved Hide resolved
@TingDaoK TingDaoK requested a review from graebm October 14, 2024 16:03
source/s3_request_messages.c Outdated Show resolved Hide resolved
source/s3_request_messages.c Show resolved Hide resolved
@TingDaoK TingDaoK requested a review from graebm October 16, 2024 17:46
@TingDaoK TingDaoK merged commit c2784aa into main Oct 17, 2024
31 checks passed
@TingDaoK TingDaoK deleted the support-header-checksum branch October 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants