Create session error code #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 88.67% 88.66% -0.02%
==========================================
Files 21 21
Lines 5953 5945 -8
==========================================
- Hits 5279 5271 -8
Misses 674 674
|
waahm7
approved these changes
Dec 6, 2023
graebm
reviewed
Dec 7, 2023
| @@ -314,16 +314,18 @@ static void s_on_request_finished( | |||
| struct aws_credentials *credentials = NULL; | |||
| int error_code = meta_request_result->error_code; | |||
|
|
|||
| if (error_code == AWS_ERROR_SUCCESS && meta_request_result->response_status != 200) { | |||
There was a problem hiding this comment.
The old logic seemed better, where we only set the special error code if the response was successfully received.
In the new way, there's no way to distinguish 4xx responses from "the connection died before I got a response".
There was a problem hiding this comment.
Updated
I am checking the request sent via the error response body to be empty or not.
graebm
approved these changes
Dec 7, 2023
| error_code = AWS_ERROR_S3EXPRESS_CREATE_SESSION_FAILED; | ||
| AWS_LOGF_ERROR( | ||
| AWS_LS_AUTH_CREDENTIALS_PROVIDER, | ||
| "(id=%p): CreateSession call failed with http status: %d, and error response body is: %.*s", |
There was a problem hiding this comment.
Nice, logging the response body 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
AWS_ERROR_S3EXPRESS_CREATE_SESSION_FAILEDfor CreateSession failed.aws_s3_response_statusto use theAWS_HTTP_STATUS_CODE*, there is no reason to keep two different set of enums for the status code. It makes me confused.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.