Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable s3express test by default #386

Closed
wants to merge 1 commit into from

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Dec 2, 2023

Issue #, if available:

  • The s3express integration tests are relied on the preconfigured buckets.

Description of changes:

  • Disable them by default for now (still have them enabled on CI)
  • TODO: update the helper to create the directory bucket as expected. (Current blocker is the boto3 client doesn't support creating directory buckets from two different regions)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #386 (e43c1ec) into main (de36fee) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   88.59%   88.61%   +0.01%     
==========================================
  Files          21       21              
  Lines        5944     5944              
==========================================
+ Hits         5266     5267       +1     
+ Misses        678      677       -1     

see 1 file with indirect coverage changes

@TingDaoK TingDaoK closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants