Skip to content

Commit

Permalink
I heart code that compiles
Browse files Browse the repository at this point in the history
  • Loading branch information
graebm committed Nov 22, 2023
1 parent ceb4cf0 commit 5d9337f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
9 changes: 0 additions & 9 deletions include/aws/s3/private/s3_request.h
Original file line number Diff line number Diff line change
Expand Up @@ -256,15 +256,6 @@ struct aws_s3_request *aws_s3_request_acquire(struct aws_s3_request *request);
AWS_S3_API
struct aws_s3_request *aws_s3_request_release(struct aws_s3_request *request);

/* Return type enum, if it is known. Otherwise AWS_S3_REQUEST_TYPE_MAX is returned. */
AWS_S3_API
enum aws_s3_request_type aws_s3_request_get_type(const struct aws_s3_request *request);

/* Return S3 operation name, if it is known. Otherwise an empty string is returned.
* Note that this C-string's lifetime is tied to the aws_s3_request. */
AWS_S3_API
const char *aws_s3_request_get_operation_name(const struct aws_s3_request *request);

AWS_S3_API
struct aws_s3_request_metrics *aws_s3_request_metrics_new(
struct aws_allocator *allocator,
Expand Down
9 changes: 0 additions & 9 deletions source/s3_default_meta_request.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ static void s_s3_meta_request_default_request_finished(
struct aws_s3_request *request,
int error_code);

static const char *s_s3_meta_request_default_operation_name(const struct aws_s3_meta_request *meta_request);

static struct aws_s3_meta_request_vtable s_s3_meta_request_default_vtable = {
.update = s_s3_meta_request_default_update,
.send_request_finish = aws_s3_meta_request_send_request_finish_default,
Expand All @@ -47,7 +45,6 @@ static struct aws_s3_meta_request_vtable s_s3_meta_request_default_vtable = {
.finished_request = s_s3_meta_request_default_request_finished,
.destroy = s_s3_meta_request_default_destroy,
.finish = aws_s3_meta_request_finish_default,
.get_operation_name = s_s3_meta_request_default_operation_name,
};

/* Allocate a new default meta request. */
Expand Down Expand Up @@ -424,9 +421,3 @@ static void s_s3_meta_request_default_request_finished(
}
/* END CRITICAL SECTION */
}

static const char *s_s3_meta_request_default_operation_name(const struct aws_s3_meta_request *meta_request) {
struct aws_s3_meta_request_default *meta_request_default = meta_request->impl;
const struct aws_string *operation_name = meta_request_default->operation_name;
return operation_name ? aws_string_c_str(operation_name) : "";
}

0 comments on commit 5d9337f

Please sign in to comment.