Support wildcards streams in request-response stream client #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 84.22% 84.27% +0.04%
==========================================
Files 24 25 +1
Lines 10398 10452 +54
==========================================
+ Hits 8758 8808 +50
- Misses 1640 1644 +4 ☔ View full report in Codecov by Sentry. |
bretambrose
reviewed
Feb 5, 2025
| @@ -0,0 +1,138 @@ | |||
| #ifndef AWS_MQTT_PRIVATE_REQUEST_RESPONSE_REQUEST_RESPONSE_SUBSCRIPTION_SET_H | |||
There was a problem hiding this comment.
I would love to see the "request_response" prefix removed somehow.
| /* | ||
| * Call specified callbacks for all stream and request operations with subscriptions matching a provided publish event. | ||
| */ | ||
| AWS_MQTT_API void aws_mqtt_request_response_client_subscriptions_match( |
There was a problem hiding this comment.
Would rename this to something ala 'handle_incoming_publish' or similar
| } | ||
|
|
||
| if (!aws_byte_cursor_eq_c_str(&subscription_topic_filter_segment, "+") && | ||
| !aws_byte_cursor_eq_ignore_case(&topic_segment, &subscription_topic_filter_segment)) { |
There was a problem hiding this comment.
I don't think case insensitive is right here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Request-response stream needs support subscriptions to topics like
$aws/some-service/<EXECUTION_ID>/etc, where<EXECUTION_ID>changes for each message published by a service.Description of changes:
Implement a module allowing to match topic filter with wildcards and a topic where PUBLISH message was received.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.